Skip to content

Fixes automatically publish package.#23678

Merged
felicitymay merged 5 commits intogithub:mainfrom
rahulpandey70:rahulpandey70-patch-1
Feb 7, 2023
Merged

Fixes automatically publish package.#23678
felicitymay merged 5 commits intogithub:mainfrom
rahulpandey70:rahulpandey70-patch-1

Conversation

@rahulpandey70
Copy link
Copy Markdown
Contributor

@rahulpandey70 rahulpandey70 commented Feb 3, 2023 •
edited by felicitymay
Loading

Why:

Closes #23487

What's being changed (if available, include any code snippets, screenshots, or gifs):

Change automatically publish package type to NPM on release. For ref #23487

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Feb 3, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 3, 2023 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/publishing-packages/publishing-nodejs-packages.md fpt
ghec
ghes@ 3.7 3.6 3.5 3.4
ghae
 fpt
ghec
ghes@ 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@Ebonsignori Ebonsignori closed this Feb 3, 2023
@cmwilson21 cmwilson21 reopened this Feb 3, 2023
@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Feb 3, 2023

@rahulpandey70 Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 3, 2023
felicitymay
felicitymay previously approved these changes Feb 7, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulpandey70 - thank you so much for this fix to the documentation ✨

I'm suggesting a couple of small changes to fix the tests and to match our style guide. Once those are merged, I'll check the preview and then this should be ready to merge.

Comment thread content/actions/publishing-packages/publishing-nodejs-packages.md Outdated
Comment thread content/actions/publishing-packages/publishing-nodejs-packages.md Outdated
@felicitymay felicitymay enabled auto-merge (squash) February 7, 2023 15:46
@felicitymay felicitymay added ready to merge This pull request is ready to merge and removed waiting for review Issue/PR is waiting for a writer's review labels Feb 7, 2023
@felicitymay felicitymay merged commit 550e85a into github:main Feb 7, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 7, 2023

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@rahulpandey70 rahulpandey70 deleted the rahulpandey70-patch-1 branch February 7, 2023 16:32
rachaelrenk pushed a commit that referenced this pull request Feb 8, 2023
@rahulpandey70 @rachaelrenk
Fixes automatically publish package. (#23678)
e672470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@felicitymay felicitymay felicitymay approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Automatically publish package to NPM on release.

5 participants

@rahulpandey70 @cmwilson21 @felicitymay @Ebonsignori @docubot